[Kde-games-devel] Review Request 111662: Hard AI for KSquares

[Tom Vincent Peters]

> On Oct. 15, 2013, 11:13 p.m., Albert Astals Cid wrote:
> > src/aicontroller.cpp, line 141
> > <http://git.reviewboard.kde.org/r/111662/diff/3/?file=185162#file185162line141>
> >
> >     This was removed because it was a no-op, right?

Yes, I didn't see a reason to keep it.


> On Oct. 15, 2013, 11:13 p.m., Albert Astals Cid wrote:
> > src/ksquareswindow.cpp, line 73
> > <http://git.reviewboard.kde.org/r/111662/diff/3/?file=185163#file185163line73>
> >
> >     Shouldn't this be Hard,Hard and not Medium,Hard?

Yes, you are right. My fault, changed it.


> On Oct. 15, 2013, 11:13 p.m., Albert Astals Cid wrote:
> > src/aicontroller.cpp, line 336
> > <http://git.reviewboard.kde.org/r/111662/diff/3/?file=185162#file185162line336>
> >
> >     This if is "new" for the "old" difficulties, isn't it? Is that something we want? or is the old one enough?

After re-reading the source and testing what happens when removing that part, I'm pretty sure it's not required. So I removed it.


> On Oct. 15, 2013, 11:13 p.m., Albert Astals Cid wrote:
> > src/aicontroller.cpp, line 190
> > <http://git.reviewboard.kde.org/r/111662/diff/3/?file=185162#file185162line190>
> >
> >     If you use a QScopedPointer here you won't need all the deletes in each and every return path, making it easier not to forget about one.

That's a really useful class I didn't know about. I used QScopedArrayPointer for myLines and linesCopy. When calling countBorderLines or memcpy, I used &(*myLines), hope that is the correct usage. 


- Tom Vincent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111662/#review41797
-----------------------------------------------------------


On Oct. 16, 2013, 7:05 p.m., Tom Vincent Peters wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111662/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 7:05 p.m.)
> 
> 
> Review request for KDE Games and Matt Williams.
> 
> 
> Repository: ksquares
> 
> 
> Description
> -------
> 
> Hard AI for KSquares, 
> originally submitted about a year ago: https://svn.reviewboard.kde.org/r/6951/
> The new AI level is able to do hard hearted handouts and doublecrosses.
> This time there are only minimal UI changes that are required for the new AI level (and some credits).
> It seems that the medium ai uses hard hearted handouts more often than before (doesn't seem to influence the strength of the medium AI, see "Testing Done")
> 
> 
> Diffs
> -----
> 
>   src/aicontroller.h beaafa8 
>   src/aicontroller.cpp 0bff5e6 
>   src/ksquareswindow.cpp 092c795 
>   src/main.cpp 58184b6 
>   src/prefs_ai.ui 9774aed 
> 
> Diff: http://git.reviewboard.kde.org/r/111662/diff/
> 
> 
> Testing
> -------
> 
> 100 autoplay games medium against hard
> a lot of games against hard ai
> some games against medium ai
> Test whether medium ai code changed as a side effect of the new code: https://git.reviewboard.kde.org/r/111705/
> 
> 
> Thanks,
> 
> Tom Vincent Peters
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131016/49eece05/attachment.html>