[Kde-games-devel] Review Request 113114: use last player controller for new players

Nemanja Hirsl nemhirsl at gmail.com
Sun Oct 13 18:39:41 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113114/#review41657
-----------------------------------------------------------


Looks good.
I'll test it for a few more days before commiting. This will also give some more time to other reviewers.

- Nemanja Hirsl


On Oct. 13, 2013, 1:03 a.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113114/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2013, 1:03 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> When adding a new player to the game, the default player controller is always the very first registered player controller (human player). Now, the used player is either the default one if no players are added yet, or the player controller of the last added player.
> 
> This fixes bug 175618.
> 
> 
> Diffs
> -----
> 
>   dialogs/newgamedlg.cc 7a2924a 
> 
> Diff: http://git.reviewboard.kde.org/r/113114/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131013/beaacd32/attachment.html>


More information about the kde-games-devel mailing list