[Kde-games-devel] Review Request 113114: use last player controller for new players

[Nemanja Hirsl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113114/#review41580
-----------------------------------------------------------



dialogs/newgamedlg.cc
<http://git.reviewboard.kde.org/r/113114/#comment30384>

    Maybe now is the time to handle this?
    If for some reason the list is empty this will crash.



dialogs/newgamedlg.cc
<http://git.reviewboard.kde.org/r/113114/#comment30386>

    The same thing for this list. 
    Check for empty for both the list and front()



dialogs/newgamedlg.cc
<http://git.reviewboard.kde.org/r/113114/#comment30387>

    What happens if config contains some of the old types?
    See line 414


- Nemanja Hirsl


On Oct. 8, 2013, 1:40 a.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113114/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2013, 1:40 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> When adding a new player to the game, the default player controller is always the very first registered player controller (human player). Now, the used player is either the default one if no players are added yet, or the player controller of the last added player.
> 
> This fixes bug 175618.
> 
> 
> Diffs
> -----
> 
>   dialogs/newgamedlg.cc be764f1 
> 
> Diff: http://git.reviewboard.kde.org/r/113114/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131012/927c800c/attachment.html>