[Kde-games-devel] Konquest: Refactor player selection

[Nemanja Hirsl]

Sorry for the mess I created this morning.

So, the patch has been reverted from 4.11:
	commit a39ffa7cd563636e2191649b8da8e0efb2571703
	Author: Nemanja Hirsl <nemhirsl at gmail.com>
	Date:   Thu Oct 10 10:34:44 2013 +0200

    	Revert "Refactor player selection and added example AI." from the 4.11
    	branch
    
   	This reverts commit 840cc42cade6f1e84894a288e1e0cf6f8b6bb060.

	commit 840cc42cade6f1e84894a288e1e0cf6f8b6bb060
	Author: Alexander Schuch <aschuch247 at gmail.com>
	Date:   Thu Oct 10 01:17:53 2013 +0000

"git revert" did a job.

It is on master only now.



Thanks,
Nemanja


On Thursday, 10. October 2013. 9.14.22 Albert Astals Cid wrote:
> Sorry for the top posting, silly webmail here
> 
> If not using REVIEW: only the creator of the review and some people with special privileges can close reviews (i just did close it).
> 
> 
> Now, I'm not sure we should have commited this to 4.11, doesn't feel like a "bugfix" to me and on the top of that seems to change i18n'able messages which we are not supposed to do without having a good reason + asking the translators.
> 
> 
> I do yhink we should revert it in 4.11. What do you guys say?
> 
> Cheers,
>   Albert
> 
> ________________________________
> De: Nemanja Hirsl <nemhirsl at gmail.com>
> Para: aacid at kde.org; Alexander Schuch <aschuch247 at gmail.com> 
> CC: kde-games-devel at kde.org 
> Enviado: Jueves 10 de octubre de 2013 10:06
> Asunto: [Kde-games-devel] Konquest: Refactor player selection
> 
> 
> Hi,
> 
> Alexander, your code for review https://git.reviewboard.kde.org/r/112676/ has been pushed to the repo. 
> I've committed it to 4.11 and merged it to master:
> commit 840cc42cade6f1e84894a288e1e0cf6f8b6bb060
> Author: Alexander Schuch <aschuch247 at gmail.com>
> Date:   Thu Oct 10 01:17:53 2013 +0000
> 
> Albert,
> Unfortunately, I missed to add REVIEW hook. How, or is there a way, to manually close the review? I don't see close menu as described here: http://www.reviewboard.org/docs/manual/1.7/users/review-requests/closing/
> 
> Thanks,
> Nemanja
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 230 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131010/61f00879/attachment.sig>