[Kde-games-devel] Konquest: Refactor player selection

[Albert Astals Cid]

Sorry for the top posting, silly webmail here

If not using REVIEW: only the creator of the review and some people with special privileges can close reviews (i just did close it).


Now, I'm not sure we should have commited this to 4.11, doesn't feel like a "bugfix" to me and on the top of that seems to change i18n'able messages which we are not supposed to do without having a good reason + asking the translators.


I do yhink we should revert it in 4.11. What do you guys say?

Cheers,
  Albert

________________________________
De: Nemanja Hirsl <nemhirsl at gmail.com>
Para: aacid at kde.org; Alexander Schuch <aschuch247 at gmail.com> 
CC: kde-games-devel at kde.org 
Enviado: Jueves 10 de octubre de 2013 10:06
Asunto: [Kde-games-devel] Konquest: Refactor player selection


Hi,

Alexander, your code for review https://git.reviewboard.kde.org/r/112676/ has been pushed to the repo. 
I've committed it to 4.11 and merged it to master:
commit 840cc42cade6f1e84894a288e1e0cf6f8b6bb060
Author: Alexander Schuch <aschuch247 at gmail.com>
Date:   Thu Oct 10 01:17:53 2013 +0000

Albert,
Unfortunately, I missed to add REVIEW hook. How, or is there a way, to manually close the review? I don't see close menu as described here: http://www.reviewboard.org/docs/manual/1.7/users/review-requests/closing/

Thanks,
Nemanja
_______________________________________________
kde-games-devel mailing list
kde-games-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel