[Kde-games-devel] Review Request 112676: refactor player selection

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112676/#review41368
-----------------------------------------------------------


Nemanja, if it looks good for you, i guess commiting it is fine (you or I do it, Alexander has no commiter rights), there's not much people around with knowledge about the code.

I'll add some silly minor comments about style, Alexander feel free to ignore it and I'll just fix it on commit (if it's me doing the commit), i'm just adding them so you see them.


dialogs/newgamedlg.cc
<http://git.reviewboard.kde.org/r/112676/#comment30278>

    const QList -> const QList &



dialogs/newgamedlg.cc
<http://git.reviewboard.kde.org/r/112676/#comment30279>

    probably a foreach(PlayerGui *player, m_selectablePlayer) {
    makes more sense



dialogs/newgamedlg.cc
<http://git.reviewboard.kde.org/r/112676/#comment30280>

    const QList &



dialogs/newgamedlg.cc
<http://git.reviewboard.kde.org/r/112676/#comment30281>

    foreach here too



dialogs/newgamedlg.cc
<http://git.reviewboard.kde.org/r/112676/#comment30282>

    qDeleteAll(m_selectablePlayer);



dialogs/newgamedlg.cc
<http://git.reviewboard.kde.org/r/112676/#comment30283>

    Just kill it if not used?



players/ai/default/default.h
<http://git.reviewboard.kde.org/r/112676/#comment30285>

    Added here, but question is for all the "new" files. Is this moved code or mostly new? If it's yours you should put your name isntead of Pierre's (and the correct year)



players/ai/default/default.h
<http://git.reviewboard.kde.org/r/112676/#comment30286>

    const



players/player_gui.cpp
<http://git.reviewboard.kde.org/r/112676/#comment30284>

    space after guiName


- Albert Astals Cid


On Oct. 2, 2013, 12:03 a.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112676/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2013, 12:03 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The default AI is handled by players/ai/default/default.cpp. The difficulty is wrapped in own classes so that the external interface is the same for all players (AI and human).
> 
> Adding new AI players is as easy as to implement the code in an own class, add a GUI wrapper (see ai/example) and add the GUI wrapper to m_selectablePlayer in NewGameDlg constructor.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0e8a354 
>   dialogs/newgamedlg.h 10ce4ee 
>   dialogs/newgamedlg.cc be764f1 
>   players/ai/default/default.h PRE-CREATION 
>   players/ai/default/default.cpp PRE-CREATION 
>   players/ai/default/hard.h PRE-CREATION 
>   players/ai/default/hard.cpp PRE-CREATION 
>   players/ai/default/hard_gui.h PRE-CREATION 
>   players/ai/default/hard_gui.cpp PRE-CREATION 
>   players/ai/default/normal.h PRE-CREATION 
>   players/ai/default/normal.cpp PRE-CREATION 
>   players/ai/default/normal_gui.h PRE-CREATION 
>   players/ai/default/normal_gui.cpp PRE-CREATION 
>   players/ai/default/weak.h PRE-CREATION 
>   players/ai/default/weak.cpp PRE-CREATION 
>   players/ai/default/weak_gui.h PRE-CREATION 
>   players/ai/default/weak_gui.cpp PRE-CREATION 
>   players/ai/example/example.h PRE-CREATION 
>   players/ai/example/example.cpp PRE-CREATION 
>   players/ai/example/example_gui.h PRE-CREATION 
>   players/ai/example/example_gui.cpp PRE-CREATION 
>   players/computerplayer.h ec25217 
>   players/computerplayer.cpp 2df7dd8 
>   players/localplayer_gui.h PRE-CREATION 
>   players/localplayer_gui.cpp PRE-CREATION 
>   players/player.h be0133a 
>   players/player_gui.h PRE-CREATION 
>   players/player_gui.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112676/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131007/6435b14e/attachment.html>