[Kde-games-devel] Review Request 113512: Animation fix for KReversi
Denis Kuplyakov
dener.kup at gmail.com
Thu Nov 21 13:28:15 UTC 2013
> On Nov. 9, 2013, 11 p.m., Albert Astals Cid wrote:
> > Looks to me that it works like it did before the QML port, good job :-)
> >
> > Please commit to KDE/4.12 and then merge to master.
>
> Albert Astals Cid wrote:
> Denis? Did you commit this to master and not to KDE/4.12? Why?
>
> Denis Kuplyakov wrote:
> Last time I have made changes, I have committed only to master... What should I do to fix things?
I've merged changes to KDE/4.12 just now.
- Denis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113512/#review43312
-----------------------------------------------------------
On Nov. 5, 2013, 4:56 p.m., Denis Kuplyakov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113512/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 4:56 p.m.)
>
>
> Review request for KDE Games, Albert Astals Cid and Viranch Mehta.
>
>
> Repository: kreversi
>
>
> Description
> -------
>
> This fixes animation for KReversi. Now chips are turning "as wave" from player's move position.
>
>
> Diffs
> -----
>
> kreversiview.h 2356fe7
> kreversiview.cpp b7a9ddf
> qml/Board.qml 60c6814
> qml/Cell.qml 2007265
> qml/Chip.qml 78d65bb
> qml/Table.qml 158ba65
>
> Diff: http://git.reviewboard.kde.org/r/113512/diff/
>
>
> Testing
> -------
>
> I have tested it a bit, seems to work.
>
>
> Thanks,
>
> Denis Kuplyakov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131121/5a5971bc/attachment.html>
More information about the kde-games-devel
mailing list