[Kde-games-devel] Review Request 113864: do not crash closing knavalbattle in the middle of an animation

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113864/#review44075
-----------------------------------------------------------

Ship it!


I think a better solution would be making the animator not a pure singleton but something that gets created and deleted by the window and then just deleting the animator on the window deletion, but that's a big rework, so yeah just commit this and then maybe work on the rework if you have time/stamina?

- Albert Astals Cid


On Nov. 14, 2013, 4:05 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113864/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 4:05 p.m.)
> 
> 
> Review request for KDE Games and Roney Gomes.
> 
> 
> Bugs: 325126
>     http://bugs.kde.org/show_bug.cgi?id=325126
> 
> 
> Repository: knavalbattle
> 
> 
> Description
> -------
> 
> stop the animation when the main window is about to be closed.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h dbac1f9 
>   src/mainwindow.cpp e3f2a35 
> 
> Diff: http://git.reviewboard.kde.org/r/113864/diff/
> 
> 
> Testing
> -------
> 
> I was able to reproduce the crash easily, now I can't.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131120/f2a9137e/attachment.html>