[Kde-games-devel] Review Request 113671: KMines: krazy fix: Using QPointers when showing modal dialogs via exec()

[Harsh Kumar]

> On Nov. 10, 2013, 4:04 a.m., Albert Astals Cid wrote:
> > Can you reproduce the crash without the patch?
> > 
> > Because i do this:
> >  * start kmines (even kmines with valgrind)
> >  * show the highscores dialog 
> >  * Call qdbus org.kde.kmines-$pidthatkmineshas /MainApplication quit
> > 
> > And there's not a crash nor a valgrind complain.

I had tried to reproduce the crash before the patch. It did not crash. I thought I was doing something wrong or missing something.
However, I submitted the patch as I thought this was a better way of writing this code.

But now that you have pointed this out, maybe we should leave this patch. I will try to find out why its not crashing.


- Harsh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113671/#review43308
-----------------------------------------------------------


On Nov. 6, 2013, 12:32 p.m., Harsh Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113671/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2013, 12:32 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kmines
> 
> 
> Description
> -------
> 
> This is to fix a issue flagged by Krazy Code Checker :
> ebn.kde.org/krazy/reports/kde-4.x/kdegames/kmines/index.html
> 
> In the fix, QPointers is used to create an object for modal dialogs which are shown via exec(). As mentioned in blogs.kde.org/node/3919, this fix will prevent crashing of the application when it is exited externally, for example by dbus.
> 
> Patch Changes the file - kmines/mainwindow.cpp
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp 078dc6e 
> 
> Diff: http://git.reviewboard.kde.org/r/113671/diff/
> 
> 
> Testing
> -------
> 
> Compiles & runs (on Arch Linux)
> 
> 
> Thanks,
> 
> Harsh Kumar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131110/9959bbc1/attachment.html>