[Kde-games-devel] Review Request 113596: Make messages list dockable.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113596/#review43313
-----------------------------------------------------------


Tried to patch it but doesn't seem to apply cleanly to master, no?


gameview.h
<http://git.reviewboard.kde.org/r/113596/#comment31188>

    Ideally here you only need the forward declaration and not the full include, but no need to change it, just it's one of the typical C++ fine-tuning things i like to suggest (i.e. only include the include when really needed)



mainwin.h
<http://git.reviewboard.kde.org/r/113596/#comment31189>

    same as in the other file



mainwin.cc
<http://git.reviewboard.kde.org/r/113596/#comment31190>

    What you need the object name for?


- Albert Astals Cid


On Nov. 9, 2013, 5:14 p.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113596/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2013, 5:14 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The messages list was always visible and always at the bottom of the game
> view. It now is a dockable widget which can be moved to any edge of the
> window or even made floating, or closed altogether.
> 
> 
> Diffs
> -----
> 
>   Konquest.cc fdabc5b 
>   gameview.h 47b9463 
>   gameview.cc a01bfde 
>   konquestui.rc cd43d33 
>   mainwin.h d72fd46 
>   mainwin.cc 929c61d 
> 
> Diff: http://git.reviewboard.kde.org/r/113596/diff/
> 
> 
> Testing
> -------
> 
> I did the main testing with a further (not yet published) patch which makes the standings overview a dock as well. Messages dock and standings dock play together nicely, even when tabbed in one dock. Fixes of issues noticed during testing there are backported to this patch now.
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131109/239380e9/attachment.html>