[Kde-games-devel] Review Request 113598: Fix "end turn" action.

Albert Astals Cid aacid at kde.org
Sat Nov 9 22:53:59 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113598/#review43310
-----------------------------------------------------------

Ship it!


Looks good to me.

- Albert Astals Cid


On Nov. 4, 2013, 12:10 a.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113598/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2013, 12:10 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The "end turn" button now is enabled/disabled depending on the game state.
> It no longer is possible to end the turn while in the middle of a send
> fleet command sequence.
> 
> Use the very same condition for enabling/disabling the custom "end turn"
> button and the "end turn" action.
> 
> The custom palette for the game board now colours disabled elements darker
> so that they actually look disabled.
> 
> This is a backport of the master fixes in 113528 for KDE 4.12.
> 
> 
> Diffs
> -----
> 
>   gameview.cc a01bfde 
>   mainwin.cc 929c61d 
> 
> Diff: http://git.reviewboard.kde.org/r/113598/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131109/c13f265d/attachment.html>


More information about the kde-games-devel mailing list