[Kde-games-devel] Review Request 113672: KMines: Krazy fix: Constructor made explicit

Alexander Schuch aschuch247 at gmail.com
Sat Nov 9 21:45:31 UTC 2013


On 9 November 2013 18:44, Yuri Chornoivan <yurchor at ukr.net> wrote:
>
> This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113672/
>
> On November 9th, 2013, 4:20 p.m. UTC, Commit Hook wrote:
>
> This review has been submitted with commit b4d3adf430e34a4668706a89bb747d9a9f13b77b by Alexander Schuch on behalf of Harsh Kumar to branch master.
>
> On November 9th, 2013, 4:23 p.m. UTC, Alexander Schuch wrote:
>
> Can someone please have a look if this all went right?
>
> On November 9th, 2013, 6:41 p.m. UTC, Harsh Kumar wrote:
>
> I have pulled from the repo. After this commit, code builds & runs.
> However, I am the one who submitted the patch, so someone else can try.
>
> Builds and works as expected.

It was the first time for me to review a patch and to commit it on
behalf of its author. I compiled it myself before as well and fully
understood the changes, I was just not certain about "the git stuff" I
did.

But from how it looks now, I probably did it "the right way". :)

Regards,
Alexander


More information about the kde-games-devel mailing list