[Kde-games-devel] Review Request 113672: KMines: Krazy fix: Constructor made explicit
Alexander Schuch
aschuch247 at gmail.com
Sat Nov 9 16:23:06 UTC 2013
> On Nov. 9, 2013, 4:20 p.m., Commit Hook wrote:
> > This review has been submitted with commit b4d3adf430e34a4668706a89bb747d9a9f13b77b by Alexander Schuch on behalf of Harsh Kumar to branch master.
Can someone please have a look if this all went right?
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113672/#review43289
-----------------------------------------------------------
On Nov. 9, 2013, 4:20 p.m., Harsh Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113672/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2013, 4:20 p.m.)
>
>
> Review request for KDE Games.
>
>
> Repository: kmines
>
>
> Description
> -------
>
> Single argument Constructor for class MineFieldItem made explicit to
> avoid mistaken implicit constructor ambiguities.
>
> This is to fix a issue flagged by Krazy Code Checker :
> ebn.kde.org/krazy/reports/kde-4.x/kdegames/kmines/index.html
>
>
> Diffs
> -----
>
> minefielditem.h a6319d3
>
> Diff: http://git.reviewboard.kde.org/r/113672/diff/
>
>
> Testing
> -------
>
> Compiles & runs (on Arch Linux)
>
>
> Thanks,
>
> Harsh Kumar
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131109/4806ca79/attachment.html>
More information about the kde-games-devel
mailing list