[Kde-games-devel] Review Request 113671: KMines: krazy fix: Using QPointers when showing modal dialogs via exec()

[Harsh Kumar]

This is a gentle reminder.
This review request has been pending for a few days.
There is also another pending review request 113672: KMines: Krazy
fix: Constructor made explicit

Harsh Kumar

On 11/6/13, Harsh Kumar <harsh1kumar at gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113671/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 12:32 p.m.)
>
>
> Review request for KDE Games.
>
>
> Summary (updated)
> -----------------
>
> KMines: krazy fix: Using QPointers when showing modal dialogs via exec()
>
>
> Repository: kmines
>
>
> Description
> -------
>
> This is to fix a issue flagged by Krazy Code Checker :
> ebn.kde.org/krazy/reports/kde-4.x/kdegames/kmines/index.html
>
> In the fix, QPointers is used to create an object for modal dialogs which
> are shown via exec(). As mentioned in blogs.kde.org/node/3919, this fix will
> prevent crashing of the application when it is exited externally, for
> example by dbus.
>
> Patch Changes the file - kmines/mainwindow.cpp
>
>
> Diffs
> -----
>
>   mainwindow.cpp 078dc6e
>
> Diff: http://git.reviewboard.kde.org/r/113671/diff/
>
>
> Testing
> -------
>
> Compiles & runs (on Arch Linux)
>
>
> Thanks,
>
> Harsh Kumar
>
>


-- 
Harsh Kumar