[Kde-games-devel] Review Request 113596: Make messages list dockable.

[Alexander Schuch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113596/
-----------------------------------------------------------

(Updated Nov. 4, 2013, 2:06 a.m.)


Review request for KDE Games.


Changes
-------

Added sizeHint() to make the main window look good for first-time users, while using the stored window dimensions for recurring users.


Summary (updated)
-----------------

Make messages list dockable.


Repository: konquest


Description
-------

The messages list was always visible and always at the bottom of the game
view. It now is a dockable widget which can be moved to any edge of the
window or even made floating, or closed altogether.


Diffs (updated)
-----

  Konquest.cc fdabc5b 
  gameview.h 47b9463 
  gameview.cc a01bfde 
  konquestui.rc cd43d33 
  mainwin.h d72fd46 
  mainwin.cc 929c61d 

Diff: http://git.reviewboard.kde.org/r/113596/diff/


Testing (updated)
-------

There is still one issue remaining with this patch:

The splash screen should not contain the message dock. This is done by hiding the dock and disabling the view menu to show it again. However, when right-clicking the menu bar, a popup is shown which allows showing/hiding the toolbar and showing/hiding the messages dock. Should we not care and even show the messages dock on the splash screen (when enabled)? Or should we care and disable that menu item there - how?


Thanks,

Alexander Schuch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131104/bd717879/attachment-0001.html>