[Kde-games-devel] Review Request 110446: This patch allows the player to resize the window. The playarea gets adjusted accordingly. This is very convenient for players using high resolution deplay.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110446/#review32661
-----------------------------------------------------------



mainwindow.cpp
<http://git.reviewboard.kde.org/r/110446/#comment24296>

    Don't leave code commented, if it's unneeded just remove it



mainwindow.cpp
<http://git.reviewboard.kde.org/r/110446/#comment24295>

    I think it'd be easier if you just created a resize() function in m_main and passed down the data you need, it'd save you from having to make public all those members and functions


- Albert Astals Cid


On May 16, 2013, 9:31 a.m., Anant  Pushkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110446/
> -----------------------------------------------------------
> 
> (Updated May 16, 2013, 9:31 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This is in reference to Bug 181978 - request for an adjustable zoom interface
> With this  patch included, the player can resize the window. The size of the playarea gets itself adjusted.
> 
> 
> Diffs
> -----
> 
>   mainarea.h 9757201 
>   mainarea.cpp 6681147 
>   mainwindow.h 1bb82ed 
>   mainwindow.cpp ad17cca 
> 
> Diff: http://git.reviewboard.kde.org/r/110446/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anant  Pushkar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130516/61809740/attachment.html>