[Kde-games-devel] Review Request 110446: This patch allows the player to resize the window. The playarea gets adjusted accordingly. This is very convenient for players using high resolution deplay.

[Albert Astals Cid]

> On May 15, 2013, 8:38 p.m., Roney Gomes wrote:
> > mainwindow.cpp, line 103
> > <http://git.reviewboard.kde.org/r/110446/diff/1/?file=143905#file143905line103>
> >
> >     Please, try to make it a constant. 33 by itself has absolutely no meaning.
> >     
> >     That's why Albert had to ask.

A constant would be better, but I don't think a it is correct, from your description it seems to me that this is probably style dependant. Also the old code doesn't seem to need this, why do you need it?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110446/#review32609
-----------------------------------------------------------


On May 15, 2013, 1:26 p.m., Anant  Pushkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110446/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 1:26 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This is in reference to Bug 181978 - request for an adjustable zoom interface
> With this  patch included, the player can resize the window. The size of the playarea gets itself adjusted.
> 
> 
> Diffs
> -----
> 
>   mainarea.h 9757201 
>   mainarea.cpp 6681147 
>   mainwindow.h 1bb82ed 
>   mainwindow.cpp ad17cca 
> 
> Diff: http://git.reviewboard.kde.org/r/110446/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anant  Pushkar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130515/13b25711/attachment.html>