[Kde-games-devel] Review Request 110258: Fix Bug 133889 - Can't reset or Zero High Game score.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110258/#review31985
-----------------------------------------------------------



highscore/kscoredialog.cpp
<http://git.reviewboard.kde.org/r/110258/#comment23829>

    unneeded whitespace change



highscore/kscoredialog.cpp
<http://git.reviewboard.kde.org/r/110258/#comment23835>

    You probably should make that "Clear" "&Clear" to put there the accelerator manually so translators know they can put an accelerator in the translation



highscore/kscoredialog.cpp
<http://git.reviewboard.kde.org/r/110258/#comment23828>

    "Sure?" is too short, you're going to need a much more verbose text there like "Are you sure you want to clear the highscores?" or similar



highscore/kscoredialog.cpp
<http://git.reviewboard.kde.org/r/110258/#comment23834>

    Haven't checked, but shouldn't clearing above be enough?



highscore/kscoredialog.cpp
<http://git.reviewboard.kde.org/r/110258/#comment23830>

    unneeded whitespace change



highscore/kscoredialog.cpp
<http://git.reviewboard.kde.org/r/110258/#comment23836>

    You probably should make that "Clear" "&Clear" to put there the accelerator manually so translators know they can put an accelerator in the translation



highscore/kscoredialog.cpp
<http://git.reviewboard.kde.org/r/110258/#comment23831>

    unneeded whitespace change



highscore/kscoredialog.cpp
<http://git.reviewboard.kde.org/r/110258/#comment23832>

    unneeded whitespace change



highscore/kscoredialog.cpp
<http://git.reviewboard.kde.org/r/110258/#comment23833>

    unneeded whitespace change


- Albert Astals Cid


On May 1, 2013, 5:27 p.m., Tatiana Baklan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110258/
> -----------------------------------------------------------
> 
> (Updated May 1, 2013, 5:27 p.m.)
> 
> 
> Review request for KDE Games, Roney Gomes and Viranch Mehta.
> 
> 
> Description
> -------
> 
> My first KDE patch.
> 
> 
> This addresses bug 133889.
>     http://bugs.kde.org/show_bug.cgi?id=133889
> 
> 
> Diffs
> -----
> 
>   highscore/kscoredialog.h cf4e6ea 
>   highscore/kscoredialog.cpp d936ee7 
> 
> Diff: http://git.reviewboard.kde.org/r/110258/diff/
> 
> 
> Testing
> -------
> 
> Tested with klines.
> 
> 
> Thanks,
> 
> Tatiana Baklan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130504/200897e3/attachment-0001.html>