[Kde-games-devel] Review Request 109687: All references to KBattleship replaced by KNavalbattle.

[Roney Gomes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109687/
-----------------------------------------------------------

(Updated March 26, 2013, 7:57 p.m.)


Review request for KDE Games.


Changes
-------

I forgot to change data/pictures/CMakeLists.txt and for this reason the resulting binary was crashing. This new diff fixes this.

As I said previously, a few files need to be changed, but this can only be done in a different patch since a renaming plus a change in the same commit will made the files loose their history.

My apologies for any inconvenience.


Description
-------

During KNavalbattle's port to QGraphicsView I was informed that it was previously called KBattleship and that this name couldn't be used anymore due copyright issues. Even so, the final compiled binary as well as the application's folder, its image and configuration files are still named making references to "kbattleship".

Thus, as I don't like to build a project called KNavalbattle and then have to call the "kbattleship" binary, I replaced all references to "kbattleship" in the building files.

A few files will appear as deleted but they were actually renamed to satisfy the new project's name. They'll appear as newly included files in the commit.


Diffs (updated)
-----

  data/pictures/hi128-app-knavalbattle.png PRE-CREATION 
  data/pictures/hi128-app-kbattleship.png e54f635 
  data/pictures/CMakeLists.txt 32c7fb3 
  CMakeLists.txt 9a4e3f8 
  data/pictures/hi16-app-kbattleship.png befa7c8 
  data/pictures/hi16-app-knavalbattle.png PRE-CREATION 
  data/pictures/hi22-app-kbattleship.png f0302bd 
  data/pictures/hi22-app-knavalbattle.png PRE-CREATION 
  data/pictures/hi32-app-kbattleship.png 7a8e63d 
  data/pictures/hi32-app-knavalbattle.png PRE-CREATION 
  data/pictures/hi48-app-kbattleship.png 9d3fd17 
  data/pictures/hi48-app-knavalbattle.png PRE-CREATION 
  data/pictures/hi64-app-kbattleship.png 69cf15f 
  data/pictures/hi64-app-knavalbattle.png PRE-CREATION 
  data/sounds/CMakeLists.txt 7833b8e 
  doc/CMakeLists.txt 4e314e5 
  doc/index.docbook 7bc34ec 
  src/CMakeLists.txt 224e890 
  src/Messages.sh 1f3f6ff 
  src/kbattleship.desktop 1bcedd9 
  src/kbattleship.kcfg bc6212b 
  src/kbattleship.protocol 7efd32e 
  src/kbattleshipui.rc 5f4f951 
  src/knavalbattle.desktop PRE-CREATION 
  src/knavalbattle.kcfg PRE-CREATION 
  src/knavalbattle.protocol PRE-CREATION 
  src/knavalbattleui.rc PRE-CREATION 
  src/main.cpp 1f8c219 
  src/settingsbase.kcfgc f62547a 

Diff: http://git.reviewboard.kde.org/r/109687/diff/


Testing
-------

A clean build and a lookup in the program's installation directory in order to check whether it all has been organized the way I intended.


Thanks,

Roney Gomes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130326/606d0140/attachment.html>