[Kde-games-devel] Review Request 109689: Change the cursor between game states.

[Roney Gomes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109689/
-----------------------------------------------------------

(Updated March 25, 2013, 6:46 p.m.)


Review request for KDE Games.


Changes
-------

Since updateCursor() is called every redraw(), then the call to unsetCursor() at closeGame() is unnecessarily anticipating updateCursor's work. Therefore it isn't needed and has been dropped out.


Description
-------

Currently, the mouse cursor keeps the same between game states, i.e., if the game is paused or the stage is cleared then the "in game" cursor will still be used.

I think that whenever the game is paused, even better, whenever there's an overlay on screen the mouse cursor shall be the system's default. The vertical and horizontal arrows shall be used only when the game is running.

Following the least responsibility principle, I've made a new method just to handle cursor variations. It checks the game state then updates the cursor accordingly.


Diffs (updated)
-----

  gamewidget.h 14abeaf 
  gamewidget.cpp d808e46 

Diff: http://git.reviewboard.kde.org/r/109689/diff/


Testing
-------

I've played the game and then checked how the cursor changed between all game states: running, paused, between levels, game over etc.


Thanks,

Roney Gomes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130325/15530271/attachment.html>