[Kde-games-devel] Review Request 108234: enable starting and stopping of demo and set action states

[Ian Simpson]

> On Jan. 23, 2013, 11:25 p.m., Christian Krippendorf wrote:
> > Looks good to me and seem to work as it should. Well done!
> 
> Albert Astals Cid wrote:
>     So what is the status of this? Was it commited or still needs work?
> 
> Albert Astals Cid wrote:
>     Jack, looks like this was never committed, I wonder why you put it against the qgraphic branch instead of the master one. Are you still interested in getting this commited? I guess master branch makes more sense if you want to have this in 4.11

I submitted this before creating an account with my real name.

The patch was for the qgraphic branch. As far as I can see, it's the only branch with the GameView class and the patch only applies there.

Christian was converting the game to use QGraphicsScene/View and was going to merge it into master but never got around to it before having to move on.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108234/#review26106
-----------------------------------------------------------


On Jan. 7, 2013, 7:42 p.m., jack daniel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108234/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2013, 7:42 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Set up the KMahjongg::demoMode() slot to start and stop the demo mode.
> 
> Add a signal/slot to react to stopping the demo or MoveListAnimation with a mouse click.
> 
> Display a message box when demo mode is lost.
> 
> 
> Diffs
> -----
> 
>   GameView.h b3f3bda 
>   GameView.cpp d652ed6 
>   kmahjongg.h 511126e 
>   kmahjongg.cpp d546732 
> 
> Diff: http://git.reviewboard.kde.org/r/108234/diff/
> 
> 
> Testing
> -------
> 
> Tried all variations of starting/stopping. Seems to work.
> 
> 
> Thanks,
> 
> jack daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130318/44d81c48/attachment.html>