[Kde-games-devel] Review Request 109494: Fix for Klickety Bug - 284309 ( color problem when undo as shapes are highlighted )
Oindrila Gupta
oindrila.gupta92 at gmail.com
Sat Mar 16 23:02:05 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109494/
-----------------------------------------------------------
(Updated March 16, 2013, 11:02 p.m.)
Review request for KDE Games, Hui Ni and Viranch Mehta.
Changes
-------
1. Followed the variable naming convention used in Klickety
2. Used padding within parenthesis to conform to the coding convention
3. Made sure that when undo is done on a piece that remains unaffected by undo, it remains highlighted
Description
-------
Kept a track of the currently hovered piece. In GameScene::undoMove() the currently highlighted pieces are first unhighlighted and then the action is undone.
This addresses bug 284309.
http://bugs.kde.org/show_bug.cgi?id=284309
Diffs
-----
gamescene.h da6de5c
gamescene.cpp 9c29e8b
Diff: http://git.reviewboard.kde.org/r/109494/diff/
Testing
-------
Thanks,
Oindrila Gupta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130316/fffc716b/attachment-0001.html>
More information about the kde-games-devel
mailing list