[Kde-games-devel] Review Request 108234: enable starting and stopping of demo and set action states
Albert Astals Cid
aacid at kde.org
Sat Mar 16 22:22:45 UTC 2013
> On Jan. 23, 2013, 11:25 p.m., Christian Krippendorf wrote:
> > Looks good to me and seem to work as it should. Well done!
So what is the status of this? Was it commited or still needs work?
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108234/#review26106
-----------------------------------------------------------
On Jan. 7, 2013, 7:42 p.m., jack daniel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108234/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2013, 7:42 p.m.)
>
>
> Review request for KDE Games.
>
>
> Description
> -------
>
> Set up the KMahjongg::demoMode() slot to start and stop the demo mode.
>
> Add a signal/slot to react to stopping the demo or MoveListAnimation with a mouse click.
>
> Display a message box when demo mode is lost.
>
>
> Diffs
> -----
>
> GameView.h b3f3bda
> GameView.cpp d652ed6
> kmahjongg.h 511126e
> kmahjongg.cpp d546732
>
> Diff: http://git.reviewboard.kde.org/r/108234/diff/
>
>
> Testing
> -------
>
> Tried all variations of starting/stopping. Seems to work.
>
>
> Thanks,
>
> jack daniel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130316/e7a4a1d8/attachment.html>
More information about the kde-games-devel
mailing list