[Kde-games-devel] Review Request 109494: Fix for Klickety Bug - 284309 ( color problem when undo as shapes are highlighted )

[Oindrila Gupta]

> On March 15, 2013, 7:22 p.m., Viranch Mehta wrote:
> > pretty clean solution. good patch!
> 
> Oindrila Gupta wrote:
>     Thank you. :)
>     Should I go ahead and ship it? However, I don't have a KDE Contributor account yet.
> 
> Viranch Mehta wrote:
>     I think it's good to go. but you should wait for the maintainer's approval.

Okay, sure.


- Oindrila


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109494/#review29288
-----------------------------------------------------------


On March 15, 2013, 10:30 a.m., Oindrila Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109494/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 10:30 a.m.)
> 
> 
> Review request for KDE Games, Hui Ni and Viranch Mehta.
> 
> 
> Description
> -------
> 
> Kept a track of the currently hovered piece. In GameScene::undoMove() the currently highlighted pieces are first unhighlighted and then the action is undone.
> 
> 
> This addresses bug 284309.
>     http://bugs.kde.org/show_bug.cgi?id=284309
> 
> 
> Diffs
> -----
> 
>   gamescene.h da6de5c 
>   gamescene.cpp 9c29e8b 
> 
> Diff: http://git.reviewboard.kde.org/r/109494/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oindrila Gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130315/2459c91c/attachment.html>