[Kde-games-devel] Review Request 109365: Support for QtQuick in libkdegames

[Viranch Mehta]

> On March 9, 2013, 8:26 a.m., Viranch Mehta wrote:
> > David Edmundson (Aug. 9, 2012, 10:50 p.m.):
> > I can see why you've done this, but for me this doesn't really work.
> > 
> > However - what I think we can do is make a wrapper round KGameRenderer and turn it into an QML ImageProvider, which may (I've not thought everything through) be a much nicer solution.
> > 
> > Viranch Mehta (Aug. 11, 2012, 12:54 p.m.):
> > That was my first approach, but the problem with it is that the image does not get updated when the theme is changed. A new pixmap is requested only when the "source" property changes, simply changing the theme does not involve changing the source, and hence the image cannot be updated. Also, there is no way to internally trigger an update so a new pixmap is requested when the theme is changed.
> > 
> > So this is the alternative approach I had to choose. What isn't working for you?
> > 
> > David Edmundson (Aug. 11, 2012, 1:10 p.m.):
> > Good point.

Now that we have name of the current theme as part of the "source" property, new pixmap is automatically requested whenever theme changes as the source property is updated.

(See KgItem.qml: source: "image://"+provider.name+"/"+provider.currentThemeName+"/"+spriteKey+"/"width+"x"+height)


- Viranch


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109365/#review28822
-----------------------------------------------------------


On March 9, 2013, 8:11 a.m., Viranch Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109365/
> -----------------------------------------------------------
> 
> (Updated March 9, 2013, 8:11 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This is a copy of review request #7017 in SVN review board because I needed to update the patch (it won't accept git diffs). Updated description:
> 
> This patch contains support for QtQuick in libkdegames for future porting QML. Post this patch, libkdeclarative becomes a dependency for libkdegames.
> 
> We have some new classes:
> 
> 1. KgImageProvider:
> This is a QDeclarativeImageProvider, and a sort-of replacement for KGameRenderer for QML ports. This class is supplied with a KgThemeProvider which it uses to discover SVG locations, reads them using QSvgRenderer and returns the requested sprite pixmap. QDeclarativeImageProvider has inbuilt ability of caching and asynchronous loading of pixmaps, which is why can replace usages of KGameRenderer in QML ports.
> 
> 2. KgDeclarativeView:
> This is a QDeclarativeView with KDE-specific import paths for QML components configured and javascript functions bindings added (like i18n() methods) using the KDeclarative library. Game's KgThemeProviders are supplied to this class which in turn registers them with the underlying QML engine, and adds KgImageProviders corresponding to each KgThemeProvider.
> 
> 3. KgItem QML component:
> This is simple QML Image element wrapper for showing sprites on QML views using the KgImageProviders. We specify which one of the KgImageProviders we want to use and which sprite key we want to show, and it will be painted on the view.
> 
> The patch may not stay up-to-date, relevant code is in "viranch/qtquick" branch in libkdegames's git repo.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 67b8b40 
>   declarativeimports/CMakeLists.txt PRE-CREATION 
>   declarativeimports/corebindingsplugin.h PRE-CREATION 
>   declarativeimports/corebindingsplugin.cpp PRE-CREATION 
>   declarativeimports/qml/KgItem.qml PRE-CREATION 
>   declarativeimports/qml/qmldir PRE-CREATION 
>   includes/CMakeLists.txt 8756a50 
>   includes/KgDeclarativeView PRE-CREATION 
>   kgdeclarativeview.h PRE-CREATION 
>   kgdeclarativeview.cpp PRE-CREATION 
>   kgimageprovider.h PRE-CREATION 
>   kgimageprovider.cpp PRE-CREATION 
>   kgthemeprovider.h 6ca9b63 
>   kgthemeprovider.cpp e186106 
> 
> Diff: http://git.reviewboard.kde.org/r/109365/diff/
> 
> 
> Testing
> -------
> 
> I'm using KBreakout to test all of this. The relevant port can be found in "qtquick/provider" branch in KBreakout's git repo.
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130309/506ce8fb/attachment.html>