[Kde-games-devel] Review Request 109365: Support for QtQuick in libkdegames

[Viranch Mehta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109365/#review28821
-----------------------------------------------------------



CMakeLists.txt
<http://git.reviewboard.kde.org/r/109365/#comment21531>

    Albert Astals Cid (Aug. 9, 2012, 10:23 p.m.):
    this is not how you do dependencies, you do a regular find + macro_log_feature
    
    Viranch Mehta (Dec. 1, 2012, 8:42 a.m.):
    Like this:
    
    find_package(KDeclarative)
    macro_log_feature(KDECLARATIVE_FOUND "KDeclarative" "KDeclarative is a KDE library for KDE specific QML support." "" TRUE "" "KDeclarative library is required for QML support in KDE Games.")
    
    ?
    
    
    Albert Astals Cid (Dec. 1, 2012, 11:59 a.m.):
    Check how it is done in other places, e.g. in the same CMakeLists.txt you are editing ;-)
    
    macro_optional_find_package(OpenAL)
    macro_log_feature(OPENAL_FOUND "OpenAL" "OpenAL (Open Audio Library) is a free software cross-platform audio API." "http://connect.creativelabs.com/openal" FALSE "" "Phonon is used as a fallback, but low-latency sound output is only available with OpenAL/SndFile.")



declarativeimports/corebindingsplugin.h
<http://git.reviewboard.kde.org/r/109365/#comment21532>

    Albert Astals Cid (Aug. 9, 2012, 10:23 p.m.):
    If we are not installing this i'd call it canvasitem_p.h
    
    Viranch Mehta (Aug. 11, 2012, 12:54 p.m.):
    How does this work? I renamed the file, changed the #include in the .cpp and the compiler gives the error that canvasitem.h file cannot be found required by the canvasitem.moc
    
    Albert Astals Cid (Aug. 11, 2012, 9:14 p.m.):
    Remove your .moc includes, this is automagically handled by cmake+automoc.
    
    That failing have a look at how kdelibs/kdeui/notifications/knotificationmanager_p.h does it
    
    Viranch Mehta (Dec. 1, 2012, 8:42 a.m.):
    Done, does this also apply to all other headers files in the patch that we are not going to ship?
    
    Albert Astals Cid (Dec. 1, 2012, 11:59 a.m.):
    Yep, non-installed headers are usually named _p.h to signal they are private.



kgdeclarativeview.h
<http://git.reviewboard.kde.org/r/109365/#comment21533>

    Albert Astals Cid (Aug. 9, 2012, 10:23 p.m.):
    
    I'd declare a d-pointer for future expandability
    
    Viranch Mehta (Aug. 11, 2012, 12:54 p.m.):
    How does this work? I haven't had any experience working with libraries.
    
    Albert Astals Cid (Aug. 11, 2012, 9:14 p.m.):
    http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++#Using_a_d-Pointer


- Viranch Mehta


On March 9, 2013, 8:11 a.m., Viranch Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109365/
> -----------------------------------------------------------
> 
> (Updated March 9, 2013, 8:11 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This is a copy of review request #7017 in SVN review board because I needed to update the patch (it won't accept git diffs). Updated description:
> 
> This patch contains support for QtQuick in libkdegames for future porting QML. Post this patch, libkdeclarative becomes a dependency for libkdegames.
> 
> We have some new classes:
> 
> 1. KgImageProvider:
> This is a QDeclarativeImageProvider, and a sort-of replacement for KGameRenderer for QML ports. This class is supplied with a KgThemeProvider which it uses to discover SVG locations, reads them using QSvgRenderer and returns the requested sprite pixmap. QDeclarativeImageProvider has inbuilt ability of caching and asynchronous loading of pixmaps, which is why can replace usages of KGameRenderer in QML ports.
> 
> 2. KgDeclarativeView:
> This is a QDeclarativeView with KDE-specific import paths for QML components configured and javascript functions bindings added (like i18n() methods) using the KDeclarative library. Game's KgThemeProviders are supplied to this class which in turn registers them with the underlying QML engine, and adds KgImageProviders corresponding to each KgThemeProvider.
> 
> 3. KgItem QML component:
> This is simple QML Image element wrapper for showing sprites on QML views using the KgImageProviders. We specify which one of the KgImageProviders we want to use and which sprite key we want to show, and it will be painted on the view.
> 
> The patch may not stay up-to-date, relevant code is in "viranch/qtquick" branch in libkdegames's git repo.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 67b8b40 
>   declarativeimports/CMakeLists.txt PRE-CREATION 
>   declarativeimports/corebindingsplugin.h PRE-CREATION 
>   declarativeimports/corebindingsplugin.cpp PRE-CREATION 
>   declarativeimports/qml/KgItem.qml PRE-CREATION 
>   declarativeimports/qml/qmldir PRE-CREATION 
>   includes/CMakeLists.txt 8756a50 
>   includes/KgDeclarativeView PRE-CREATION 
>   kgdeclarativeview.h PRE-CREATION 
>   kgdeclarativeview.cpp PRE-CREATION 
>   kgimageprovider.h PRE-CREATION 
>   kgimageprovider.cpp PRE-CREATION 
>   kgthemeprovider.h 6ca9b63 
>   kgthemeprovider.cpp e186106 
> 
> Diff: http://git.reviewboard.kde.org/r/109365/diff/
> 
> 
> Testing
> -------
> 
> I'm using KBreakout to test all of this. The relevant port can be found in "qtquick/provider" branch in KBreakout's git repo.
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130309/987b247a/attachment-0001.html>