[Kde-games-devel] Review Request 109800: [PATCH] Fix for click-and-drag alternative

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109800/#review35323
-----------------------------------------------------------


I'm not sure i understand your approach, why do you need to measure time at all to implement the feature?


dealer.cpp
<http://git.reviewboard.kde.org/r/109800/#comment25864>

    What does this line do?


- Albert Astals Cid


On June 19, 2013, 6:36 a.m., Saurav Singhi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109800/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 6:36 a.m.)
> 
> 
> Review request for KDE Games, Parker Coates and Viranch Mehta.
> 
> 
> Description
> -------
> 
> This patch applies to kpat/dealer.h and kpat/dealer.cpp
> 
> I have introduced a QTime variable clickTime in th class DealerScene to measure the time difference between mouse press and mouse release. Mouse press is treated as single click and if mouse is released before 500 ms the release function does nothing. The release statements are executed the next time mouse is clicked.
> 
> 
> This addresses bug 249812.
>     http://bugs.kde.org/show_bug.cgi?id=249812
> 
> 
> Diffs
> -----
> 
>   dealer.h 9db2087 
>   dealer.cpp 1de913f 
> 
> Diff: http://git.reviewboard.kde.org/r/109800/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Saurav Singhi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130630/27437580/attachment.html>