[Kde-games-devel] Review Request 109800: [PATCH] Fix for click-and-drag alternative

[Albert Astals Cid]

> On April 2, 2013, 10:23 p.m., Albert Astals Cid wrote:
> > dealer.cpp, line 1097
> > <http://git.reviewboard.kde.org/r/109800/diff/1/?file=126710#file126710line1097>
> >
> >     I'm not a KPat expert but calling KCardScene::mousReleaseEvent from mousePressEvent does look weird
> 
> Saurav Singhi wrote:
>     i have not used this line for the first time. It was used before as well.
> 
> Albert Astals Cid wrote:
>     I don't see that the original code has any mouseReleaseEvent call inside the mousePressEvent, can you point where?
> 
> Saurav Singhi wrote:
>     sir mouseReleaseEvent is called from inside mouseReleaseEvent and same with mousePressEvent.

First, please, stop calling me Sir.

Second, can you please give me the line number and file of where the original code calls mouseReleaseEvent inside the mousePressEvent?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109800/#review30300
-----------------------------------------------------------


On June 19, 2013, 6:36 a.m., Saurav Singhi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109800/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 6:36 a.m.)
> 
> 
> Review request for KDE Games, Parker Coates and Viranch Mehta.
> 
> 
> Description
> -------
> 
> This patch applies to kpat/dealer.h and kpat/dealer.cpp
> 
> I have introduced a QTime variable clickTime in th class DealerScene to measure the time difference between mouse press and mouse release. Mouse press is treated as single click and if mouse is released before 500 ms the release function does nothing. The release statements are executed the next time mouse is clicked.
> 
> 
> This addresses bug 249812.
>     http://bugs.kde.org/show_bug.cgi?id=249812
> 
> 
> Diffs
> -----
> 
>   dealer.h 9db2087 
>   dealer.cpp 1de913f 
> 
> Diff: http://git.reviewboard.kde.org/r/109800/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Saurav Singhi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130623/5292b254/attachment.html>