[Kde-games-devel] Review Request 109800: [PATCH] Fix for click-and-drag alternative

[Albert Astals Cid]

> On April 4, 2013, 3:05 a.m., Roney Gomes wrote:
> > dealer.h, line 75
> > <http://git.reviewboard.kde.org/r/109800/diff/1/?file=126709#file126709line75>
> >
> >     Why did you make this public?
> 
> Saurav Singhi wrote:
>     i did not think it would matter. Should I make it private?
> 
> Saurav Singhi wrote:
>     i have made it private.

Have you published your new patch? I still see it as public.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109800/#review30347
-----------------------------------------------------------


On March 30, 2013, 2:51 p.m., Saurav Singhi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109800/
> -----------------------------------------------------------
> 
> (Updated March 30, 2013, 2:51 p.m.)
> 
> 
> Review request for KDE Games and Viranch Mehta.
> 
> 
> Description
> -------
> 
> This patch applies to kpat/dealer.h and kpat/dealer.cpp
> 
> I have introduced a QTime variable clickTime in th class DealerScene to measure the time difference between mouse press and mouse release. Mouse press is treated as single click and if mouse is released before 500 ms the release function does nothing. The release statements are executed the next time mouse is clicked.
> 
> 
> This addresses bug 249812.
>     http://bugs.kde.org/show_bug.cgi?id=249812
> 
> 
> Diffs
> -----
> 
>   dealer.h 9db2087 
>   dealer.cpp 1de913f 
> 
> Diff: http://git.reviewboard.kde.org/r/109800/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Saurav Singhi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130618/206f703c/attachment-0001.html>