[Kde-games-devel] Review Request 109800: [PATCH] Fix for click-and-drag alternative

Saurav Singhi saurav.singhi at gmail.com
Mon Jun 17 04:33:49 UTC 2013



> On June 16, 2013, 2:14 p.m., Albert Astals Cid wrote:
> > Saurav are you there? Any chance you answer our questions? Or shall we discard the review?

I am very sorry sir. I am a new contributor and the replies were stored as drafts that considered were published. I think i have corrected my mistake and the new diff is taking all the comments into consideration.


- Saurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109800/#review34420
-----------------------------------------------------------


On March 30, 2013, 2:51 p.m., Saurav Singhi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109800/
> -----------------------------------------------------------
> 
> (Updated March 30, 2013, 2:51 p.m.)
> 
> 
> Review request for KDE Games and Viranch Mehta.
> 
> 
> Description
> -------
> 
> This patch applies to kpat/dealer.h and kpat/dealer.cpp
> 
> I have introduced a QTime variable clickTime in th class DealerScene to measure the time difference between mouse press and mouse release. Mouse press is treated as single click and if mouse is released before 500 ms the release function does nothing. The release statements are executed the next time mouse is clicked.
> 
> 
> This addresses bug 249812.
>     http://bugs.kde.org/show_bug.cgi?id=249812
> 
> 
> Diffs
> -----
> 
>   dealer.h 9db2087 
>   dealer.cpp 1de913f 
> 
> Diff: http://git.reviewboard.kde.org/r/109800/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Saurav Singhi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130617/60a768d7/attachment.html>


More information about the kde-games-devel mailing list