[Kde-games-devel] Review Request 110788: KFourInLine: Player color names fix

[Albert Astals Cid]

> On June 10, 2013, 11:07 p.m., Albert Astals Cid wrote:
> > grafix/default.rc, line 238
> > <http://git.reviewboard.kde.org/r/110788/diff/5/?file=149516#file149516line238>
> >
> >     Why all these changes in fontColorActive & friends?
> 
> Eneko Nieto wrote:
>     Player colors in score board was a mess:
>     
>     BEFORE
>     Black and red theme: red for black player, black for red player, yellow for active player.
>     Yellow and red theme: white for yellow player, red for red player, yellow for active player.
>     
>     NOW
>     Black and red theme: black for black player, red for red player, white for active player.
>     Yellow and red theme: yellow for yellow player, red for red player, white for active player.

Ok, we are in message freeze for 4.11 so we need an exemption from the i18n guys. I'll ask for it.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110788/#review34099
-----------------------------------------------------------


On June 10, 2013, 10:55 p.m., Eneko Nieto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110788/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 10:55 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Added player color names to theme files. This helps fixing inconsistencies in naming player colors because different themes uses different colors.
> 
> 
> This addresses bug 154687.
>     http://bugs.kde.org/show_bug.cgi?id=154687
> 
> 
> Diffs
> -----
> 
>   grafix/default.desktop 7a78ad9 
>   grafix/default.rc 006f510 
>   grafix/gray_reflection.desktop 60be4aa 
>   grafix/gray_reflection.rc 174a025 
>   grafix/yellow.desktop 582c3e1 
>   grafix/yellow.rc 45787cc 
>   grafix/yellow_reflection.desktop 17d8fe2 
>   grafix/yellow_reflection.rc 3ef8d76 
>   src/kwin4.h af0a2e5 
>   src/kwin4.cpp 03be331 
>   src/thememanager.cpp 7683bf2 
> 
> Diff: http://git.reviewboard.kde.org/r/110788/diff/
> 
> 
> Testing
> -------
> 
> Tested all themes. Only color names in status bar have been fixed.
> 
> Color names in settings dialog have not been fixed because settings dialog remove in near future.
> 
> 
> Thanks,
> 
> Eneko Nieto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130611/5f7d0e46/attachment-0001.html>