[Kde-games-devel] Review Request 110848: Fix bug 314763. Board construction sometimes does not terminate

[Albert Astals Cid]

> On June 10, 2013, 7:14 p.m., Ashwin Rajeev wrote:
> > Ship It!

Ian when you do the commit, please commit it to KDE/4.10 branch first and then merge that branch to master?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110848/#review34078
-----------------------------------------------------------


On June 8, 2013, 6:06 p.m., Ian Simpson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110848/
> -----------------------------------------------------------
> 
> (Updated June 8, 2013, 6:06 p.m.)
> 
> 
> Review request for KDE Games and Ashwin Rajeev.
> 
> 
> Description
> -------
> 
> Empty cells inside loop, before each attempt to create a grid.
> 
> 
> This addresses bug 314763.
>     http://bugs.kde.org/show_bug.cgi?id=314763
> 
> 
> Diffs
> -----
> 
>   src/abstractgrid.cpp 35a6481 
> 
> Diff: http://git.reviewboard.kde.org/r/110848/diff/
> 
> 
> Testing
> -------
> 
> Must have started a few hundred games at various levels and always created a grid.
> 
> 
> Thanks,
> 
> Ian Simpson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130610/b9b00b77/attachment.html>