[Kde-games-devel] Review Request 110788: KFourInLine: Player color names fix

[Albert Astals Cid]

> On June 9, 2013, 11:15 a.m., Albert Astals Cid wrote:
> > Do you think you can fix the "Black Plays With"/"Red Plays With" using this new thing? Or you prefer we commit this first and fix that later?
> 
> Eneko Nieto wrote:
>     I was not fixing the settings dialog because it will be removed with the planned changes. I am working in them right now, but advancing slow, still too much qt to learn.
> 
> Albert Astals Cid wrote:
>     Thing is, your new dialog can't go into 4.11 (which will be released soon) because it's a new feature, but this and the change to make "Black Plays With"/"Red Plays With" use your new colors could, since they fix bugs. So hence my question, do you want me to commit this first and then you work on fixing the other bug for 4.11 or you prefer to wait for the new feature for 4.12 or?
>     
>     Do not hesitate to tell me if i'm not explaining myself correctly enough
> 
> Eneko Nieto wrote:
>     I think it would be nice to have the bugfixes for 4.11, I'll try to get them.
>     
>     In kwin4.cpp:906 added following line but text was not modified:
>     
>     ui.kcfg_startcolourred->setText("test");
>     
>     How can I change that text in a dynamic way?
>     
>     Thanks for the help

Works here, see http://i.imgur.com/NmQ3KV9.png


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110788/#review33979
-----------------------------------------------------------


On June 3, 2013, 11:36 p.m., Eneko Nieto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110788/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 11:36 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Added player color names to theme files. This helps fixing inconsistencies in naming player colors because different themes uses different colors.
> 
> 
> This addresses bug 154687.
>     http://bugs.kde.org/show_bug.cgi?id=154687
> 
> 
> Diffs
> -----
> 
>   grafix/default.desktop 7a78ad9 
>   grafix/gray_reflection.desktop 60be4aa 
>   grafix/yellow.desktop 582c3e1 
>   grafix/yellow_reflection.desktop 17d8fe2 
>   src/kwin4.h af0a2e5 
>   src/kwin4.cpp 03be331 
>   src/thememanager.cpp 7683bf2 
> 
> Diff: http://git.reviewboard.kde.org/r/110788/diff/
> 
> 
> Testing
> -------
> 
> Tested all themes. Only color names in status bar have been fixed.
> 
> Color names in settings dialog have not been fixed because settings dialog remove in near future.
> 
> 
> Thanks,
> 
> Eneko Nieto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130610/ae896fdc/attachment.html>