[Kde-games-devel] Review Request 110848: Fix bug 314763. Board construction sometimes does not terminate

[Ashwin Rajeev]

> On June 6, 2013, 8:55 p.m., Albert Astals Cid wrote:
> > Hmmm, the bug says "KDE Platform Version: 4.10.00 (Compiled from sources)" while this new looping code was just introduced in 4.10.3. Are you sure this is fixing the crash? I.e. can you reproduce the problem without the patch?
> 
> Ian Simpson wrote:
>     Yeah, the problem is still there for me. I saw the bug report, cloned it and tried it out. The last commit in the git log is "fix wrong app name" from 2013-05-06. About KNetWalk shows version 4.10.3. Start it up, hold down Ctrl+N and it'll eventually hang.
> 
> Albert Astals Cid wrote:
>     Right, I just added a test that proves it (i.e. run the test and it'll never finish).

@Albert : I didn't change any logic inside createGrid(), only changed some variable name. So i don't think that looping code was introduced in 4.10.3. Shuffling code and createGrid are different. 
Anyway this patch seems to solve the issue.


- Ashwin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110848/#review33881
-----------------------------------------------------------


On June 8, 2013, 6:06 p.m., Ian Simpson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110848/
> -----------------------------------------------------------
> 
> (Updated June 8, 2013, 6:06 p.m.)
> 
> 
> Review request for KDE Games and Ashwin Rajeev.
> 
> 
> Description
> -------
> 
> Empty cells inside loop, before each attempt to create a grid.
> 
> 
> This addresses bug 314763.
>     http://bugs.kde.org/show_bug.cgi?id=314763
> 
> 
> Diffs
> -----
> 
>   src/abstractgrid.cpp 35a6481 
> 
> Diff: http://git.reviewboard.kde.org/r/110848/diff/
> 
> 
> Testing
> -------
> 
> Must have started a few hundred games at various levels and always created a grid.
> 
> 
> Thanks,
> 
> Ian Simpson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130610/83d30875/attachment.html>