[Kde-games-devel] Review Request 110788: KFourInLine: Player color names fix

[Eneko Nieto]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110788/
-----------------------------------------------------------

(Updated June 3, 2013, 2:29 a.m.)


Review request for KDE Games.


Changes
-------

Forgot previous patch, it always uses default theme color names.

I cannot test if translations are working, my development environment is in english only, I'll try to fix to test properly before submitting future patches.


Description
-------

Added player color names to theme files. This helps fixing inconsistencies in naming player colors because different themes uses different colors.


This addresses bug 154687.
    http://bugs.kde.org/show_bug.cgi?id=154687


Diffs (updated)
-----

  grafix/default.desktop 7a78ad9 
  grafix/gray_reflection.desktop 60be4aa 
  grafix/yellow.desktop 582c3e1 
  grafix/yellow_reflection.desktop 17d8fe2 
  src/kwin4.h af0a2e5 
  src/kwin4.cpp 03be331 
  src/thememanager.cpp 7683bf2 

Diff: http://git.reviewboard.kde.org/r/110788/diff/


Testing
-------

Tested all themes. Only color names in status bar have been fixed.

Color names in settings dialog have not been fixed because settings dialog remove in near future.


Thanks,

Eneko Nieto

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130603/0d48dcd2/attachment.html>