[Kde-games-devel] Review Request 110788: KFourInLine: Player color names fix

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110788/#review33596
-----------------------------------------------------------


Problem, now Red/Yellow/Black are untranslatable.

I know how to fix it (it's not an awesome solution but it'll do), but i'll let you think about it for a while, if you can't find how to do it, complain here and i'll give you some more pointers.

- Albert Astals Cid


On June 2, 2013, 8:11 p.m., Eneko Nieto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110788/
> -----------------------------------------------------------
> 
> (Updated June 2, 2013, 8:11 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Added player color names to theme files. This helps fixing inconsistencies in naming player colors because different themes uses different colors.
> 
> 
> This addresses bug 154687.
>     http://bugs.kde.org/show_bug.cgi?id=154687
> 
> 
> Diffs
> -----
> 
>   grafix/default.rc 006f510 
>   grafix/gray_reflection.rc 174a025 
>   grafix/yellow.rc 45787cc 
>   grafix/yellow_reflection.rc 3ef8d76 
>   src/kwin4.cpp 03be331 
>   src/thememanager.h 0c75195 
>   src/thememanager.cpp 7683bf2 
> 
> Diff: http://git.reviewboard.kde.org/r/110788/diff/
> 
> 
> Testing
> -------
> 
> Tested all themes. Only color names in status bar have been fixed.
> 
> Color names in settings dialog have not been fixed because settings dialog remove in near future.
> 
> 
> Thanks,
> 
> Eneko Nieto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130602/e3b540bc/attachment.html>