[Kde-games-devel] Review Request 110650: Enable ctrl-m (by default) to toggle the menubar, with a prompt.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110650/#review33554
-----------------------------------------------------------


Still not working (i.e. i get the dialog when pressing Ctrl+m when starting a game with the menubar hidden).
FWIW
qDebug() << "EEEEEEEEEEEEEEE" << menuBar()->isHidden();
returns false (in the position you're using it) even when the menubar is hidden, it's probably a bit too early in the construction process.

- Albert Astals Cid


On May 30, 2013, 11:26 p.m., Matthew Scheirer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110650/
> -----------------------------------------------------------
> 
> (Updated May 30, 2013, 11:26 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Adds the ctrl-m standard keyboard shortcut to hide the menubar, with a warning prompt. Mainly for my grandfather who would right click the menubar and diable the main toolbar and not know what to do.
> 
> 
> This addresses bug 320269.
>     http://bugs.kde.org/show_bug.cgi?id=320269
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp a42f8ef 
>   mainwindow.h c9cbeae 
> 
> Diff: http://git.reviewboard.kde.org/r/110650/diff/
> 
> 
> Testing
> -------
> 
> Shortcut works, settings preserved across multiple sessions.
> 
> 
> Thanks,
> 
> Matthew Scheirer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130601/f2597367/attachment.html>