[Kde-games-devel] Review Request 109800: [PATCH] Fix for click-and-drag alternative

[Albert Astals Cid]

> On June 30, 2013, 9:08 p.m., Albert Astals Cid wrote:
> > dealer.cpp, line 1055
> > <http://git.reviewboard.kde.org/r/109800/diff/2/?file=138542#file138542line1055>
> >
> >     What does this line do?
> 
> Saurav Singhi wrote:
>     i am measuring time to distinguish between single click and click and drag(or a long click). this line ensures that the user cannot drag before the default drag time of 250ms.
> 
> Albert Astals Cid wrote:
>     But why do you need time at all? Press and release in the same place -> click, Press + move -> drag. None of the widgets i can find in any of my desktop apps (listviews, etc) seem to take time into account for dragging
> 
> Saurav Singhi wrote:
>     i did not study other apps. I thought that a long click also should also be considered a click and drag even if the user did not move the mouse so i used time.

Please have a look at how most of the other apps work, i think they most behave like I said, and it is good if we can make most app behave coherently


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109800/#review35323
-----------------------------------------------------------


On June 19, 2013, 6:36 a.m., Saurav Singhi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109800/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 6:36 a.m.)
> 
> 
> Review request for KDE Games, Parker Coates and Viranch Mehta.
> 
> 
> Description
> -------
> 
> This patch applies to kpat/dealer.h and kpat/dealer.cpp
> 
> I have introduced a QTime variable clickTime in th class DealerScene to measure the time difference between mouse press and mouse release. Mouse press is treated as single click and if mouse is released before 500 ms the release function does nothing. The release statements are executed the next time mouse is clicked.
> 
> 
> This addresses bug 249812.
>     http://bugs.kde.org/show_bug.cgi?id=249812
> 
> 
> Diffs
> -----
> 
>   dealer.h 9db2087 
>   dealer.cpp 1de913f 
> 
> Diff: http://git.reviewboard.kde.org/r/109800/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Saurav Singhi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130718/a0631dbd/attachment.html>