[Kde-games-devel] Review Request 108567: Fix scene/view corruption on window resize

[Christian Krippendorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108567/#review26105
-----------------------------------------------------------


The doesn't seem to be a good one. The new images will be created two times. The function resizeTileset() should take care of the process a resize of tiles is needed. The new item positions are also created in resizeTileset(). There must be be a better smarter solution.

- Christian Krippendorf


On Jan. 23, 2013, 8:48 p.m., Ian Simpson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108567/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2013, 8:48 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Scene/view was corrupted after resizing the window. Removed tiles were being drawn at their original size.
> 
> Appears fixed by calling addItemsFromBoardLayout() in order to recreate the scene.
> 
> 
> Diffs
> -----
> 
>   GameView.cpp d652ed6 
> 
> Diff: http://git.reviewboard.kde.org/r/108567/diff/
> 
> 
> Testing
> -------
> 
> Tried some different layouts at different states of play, and the gameover replay animation.
> 
> 
> Thanks,
> 
> Ian Simpson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130123/9888d6f7/attachment-0001.html>