[Kde-games-devel] Review Request 108460: On selecting new game don't abort existing game without confirmation

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108460/#review25761
-----------------------------------------------------------

Ship it!


Just a few code style issues. I realise the code style isn't 100% consistent to start with, but it's usually best to try to match the style of surrounding code.


gameview.h
<http://git.reviewboard.kde.org/r/108460/#comment19600>

    Tab indentation instead of spaces.



gameview.cc
<http://git.reviewboard.kde.org/r/108460/#comment19601>

    Opening brace should be on its own line.



gameview.cc
<http://git.reviewboard.kde.org/r/108460/#comment19603>

    Extra space after "if". Missing spaces inside paratheses.


- Parker Coates


On Jan. 18, 2013, 8:07 p.m., Michael Reeves wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108460/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2013, 8:07 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> When selecting new game with a game already running the old game automaticly aborts without warning.
> 
> 
> Diffs
> -----
> 
>   gameview.h f8ca719 
>   gameview.cc 3d0c97c 
>   mainwin.cc 366ab96 
> 
> Diff: http://git.reviewboard.kde.org/r/108460/diff/
> 
> 
> Testing
> -------
> 
> Verified that confirmation dialog comes up if a game is already running. Confirmed that cancling new game dialog or clicking no in confirmation dialog does not abort exiting game.
> 
> 
> Thanks,
> 
> Michael Reeves
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130118/ccf4fc9c/attachment.html>