[Kde-games-devel] Review Request 108068: Ksirk Bug 309863 - just playing when crashes

[Nemanja Hirsl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108068/#review24374
-----------------------------------------------------------



ksirk/decoratedgameframe.cpp
<http://git.reviewboard.kde.org/r/108068/#comment19360>

    The original idea was to disable this item from context menu. Not all paths were covered.



ksirk/krightdialog.cpp
<http://git.reviewboard.kde.org/r/108068/#comment18692>

    The actual crash happened here because loading labeled has been already cleared.
    Keep the code for safety reasons.



ksirk/krightdialog.cpp
<http://git.reviewboard.kde.org/r/108068/#comment19361>

    I'm not 100% sure that this won't happen again, but if it occurs, do not crash. Log that item(s) has already been cleared and proceed. The result is complete right widget, but just two labels, for a couple of seconds won't be refreshed.


- Nemanja Hirsl


On Jan. 13, 2013, 1:44 p.m., Nemanja Hirsl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108068/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 1:44 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> The crash occurs when AI is playing or Auto attack is going on and user wants to see country details from context menu. Both country and fight details are shown in the right dialog interfering with each other. Some safety code is added to prevent new crashes.
> The complete solution is to disable detailed country view from the context menu when AI is playing or Auto Attack is under way. This separates appearing of two views at the same time in the right dialog.
> 
> 
> This addresses bug 309863.
>     http://bugs.kde.org/show_bug.cgi?id=309863
> 
> 
> Diffs
> -----
> 
>   ksirk/decoratedgameframe.cpp 7c6941e 
>   ksirk/krightdialog.cpp 94fd89f 
> 
> Diff: http://git.reviewboard.kde.org/r/108068/diff/
> 
> 
> Testing
> -------
> 
> 1. While AI is playing bring up context menu (right click on the country). No more "Details" entry.
> 2. While Auto Attack bring up context menu. No more "Details" entry.
> 
> 
> Thanks,
> 
> Nemanja Hirsl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130113/19e31328/attachment-0001.html>