[Kde-games-devel] Review Request 108068: Ksirk Bug 309863 - just playing when crashes

[Wolfgang Rohdewald]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108068/#review25366
-----------------------------------------------------------


I did not try your changes (actually I never played this game), but anyway ...


ksirk/decoratedgameframe.cpp
<http://git.reviewboard.kde.org/r/108068/#comment19358>

    not sure - do you fix the cause or the symptoms? It seems you are removing functionality from the user view. Would it be possible to make the shared resources shareable? If not, could you please add the reason to the comment?



ksirk/krightdialog.cpp
<http://git.reviewboard.kde.org/r/108068/#comment19359>

    The fixing commit should be as small as possible, so it is easier to review.
    
    So - if you think this should not happen anymore, why is this change needed? If you strongly believe so but are not 100% sure, would it be better to make this an assertion or at least generate warning output if it happens?



ksirk/krightdialog.cpp
<http://git.reviewboard.kde.org/r/108068/#comment19356>

    trailing whitespace


- Wolfgang Rohdewald


On Jan. 1, 2013, 6:50 p.m., Nemanja Hirsl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108068/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2013, 6:50 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> The crash occurs when AI is playing or Auto attack is going on and user wants to see country details from context menu. Both country and fight details are shown in the right dialog interfering with each other. Some safety code is added to prevent new crashes.
> The complete solution is to disable detailed country view from the context menu when AI is playing or Auto Attack is under way. This separates appearing of two views at the same time in the right dialog.
> 
> 
> This addresses bug 309863.
>     http://bugs.kde.org/show_bug.cgi?id=309863
> 
> 
> Diffs
> -----
> 
>   ksirk/decoratedgameframe.cpp 7c6941e 
>   ksirk/krightdialog.cpp 94fd89f 
> 
> Diff: http://git.reviewboard.kde.org/r/108068/diff/
> 
> 
> Testing
> -------
> 
> 1. While AI is playing bring up context menu (right click on the country). No more "Details" entry.
> 2. While Auto Attack bring up context menu. No more "Details" entry.
> 
> 
> Thanks,
> 
> Nemanja Hirsl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130113/42685d70/attachment.html>