[Kde-games-devel] Review Request 108606: Add an option to change the row height

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108606/#review26721
-----------------------------------------------------------



src/itemdelegate.cpp
<http://git.reviewboard.kde.org/r/108606/#comment20289>

    I understand that not making row 0 bigger makes sense, but i find a bit ugly when i make the rows bigger and somehow there are three rows of different sizes, do you like it much more this way?



src/itemdelegate.cpp
<http://git.reviewboard.kde.org/r/108606/#comment20290>

    Haven't tried if it works, but could you try something along this lines
    QStyleOptionViewItemV4 opt = option;
    opt.font.setPointSize(m_height);
    return QItemDelegate::sizeHint(opt, index);


- Albert Astals Cid


On Jan. 29, 2013, 9:25 p.m., Ian Simpson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108606/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2013, 9:25 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Adds a configuration option to set the row height of the tableview.
> 
> Would have liked to prevent the height being set smaller than the font size. I tried to figure out how to get hold of the rowHeight spinbox in order to set its minimum value to that of the font size when it was changed, but couldn't. Anyone give me a hint? :-)
> 
> Other than that it seems to work OK.
> 
> 
> This addresses bug 309428.
>     http://bugs.kde.org/show_bug.cgi?id=309428
> 
> 
> Diffs
> -----
> 
>   src/itemdelegate.h PRE-CREATION 
>   src/configwidget.cpp 30851ae 
>   src/configwidget.h e35be7a 
>   src/configPage.ui 5382a33 
>   src/CMakeLists.txt 1a0f3a8 
>   src/itemdelegate.cpp PRE-CREATION 
>   src/kiriki.h 357b771 
>   src/kiriki.cpp 4571d8f 
>   src/kiriki.kcfg 785991a 
> 
> Diff: http://git.reviewboard.kde.org/r/108606/diff/
> 
> 
> Testing
> -------
> 
> Simply played a few games, changing the font size and row height.
> 
> 
> Thanks,
> 
> Ian Simpson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130205/d86760ee/attachment-0001.html>