[Kde-games-devel] ksirk bugs correction

[Kleag]

Hi Nemanja,

You have now corrected several bugs for ksirk and submitted patches for them. 
All have been accepted. I think that you should now, if you wish, apply for a 
write access to the KDE repository, thus you will be able to push yourself  
your accepted patches. The process will be quicker than waiting for me to 
apply them (more on this in my next mail).

Regards,

Gaël
 
Le samedi 2 février 2013 12:00:01 kde-games-devel-request at kde.org a écrit :
> 
> Message: 1
> Date: Sat, 02 Feb 2013 11:46:08 -0000
> From: Ga?l de Chalendar <kleag at free.fr>
> To: Nemanja Hirsl <nemhirsl at gmail.com>, Albert Astals Cid
> 	<aacid at kde.org>, Ga?l de Chalendar <kleag at free.fr>, KDE Games
> 	<kde-games-devel at kde.org>
> Subject: Re: [Kde-games-devel] Review Request 108068: Ksirk Bug 309863
> 	-	just playing when crashes
> Message-ID: <20130202114608.24161.91698 at vidsolbach.de>
> Content-Type: text/plain; charset="utf-8"
> 
> > On Jan. 27, 2013, 9:18 p.m., Albert Astals Cid wrote:
> > > Ga?l you there? This patch looks sensible to me, do you think we should
> > > commit it to 4.10 branch before wednesday so it gets into 4.10.0
> > > release?
> It seems very good to me. I'll try to apply the patch this weekend.
> 
> 
> - Ga?l de
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108068/#review26285
> -----------------------------------------------------------
> 
> On Jan. 13, 2013, 1:44 p.m., Nemanja Hirsl wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/108068/
> > -----------------------------------------------------------
> > 
> > (Updated Jan. 13, 2013, 1:44 p.m.)
> > 
> > 
> > Review request for KDE Games.
> > 
> > 
> > Description
> > -------
> > 
> > The crash occurs when AI is playing or Auto attack is going on and user
> > wants to see country details from context menu. Both country and fight
> > details are shown in the right dialog interfering with each other. Some
> > safety code is added to prevent new crashes. The complete solution is to
> > disable detailed country view from the context menu when AI is playing or
> > Auto Attack is under way. This separates appearing of two views at the
> > same time in the right dialog.
> > 
> > 
> > This addresses bug 309863.
> > 
> >     http://bugs.kde.org/show_bug.cgi?id=309863
> > 
> > Diffs
> > -----
> > 
> >   ksirk/decoratedgameframe.cpp 7c6941e
> >   ksirk/krightdialog.cpp 94fd89f
> > 
> > Diff: http://git.reviewboard.kde.org/r/108068/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > 1. While AI is playing bring up context menu (right click on the country).
> > No more "Details" entry. 2. While Auto Attack bring up context menu. No
> > more "Details" entry.
> > 
> > 
> > Thanks,
> > 
> > Nemanja Hirsl
> 
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130202/39be743
> 6/attachment-0001.html>
> 
> ------------------------------
> 
> Message: 2
> Date: Sat, 02 Feb 2013 11:46:21 -0000
> From: Ga?l de Chalendar <kleag at free.fr>
> To: Nemanja Hirsl <nemhirsl at gmail.com>, Ga?l de Chalendar
> 	<kleag at free.fr>, KDE Games <kde-games-devel at kde.org>
> Subject: Re: [Kde-games-devel] Review Request 108068: Ksirk Bug 309863
> 	-	just playing when crashes
> Message-ID: <20130202114621.24161.27668 at vidsolbach.de>
> Content-Type: text/plain; charset="utf-8"
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108068/#review26539
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Ship It!
> 
> - Ga?l de Chalendar
> 
> On Jan. 13, 2013, 1:44 p.m., Nemanja Hirsl wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/108068/
> > -----------------------------------------------------------
> > 
> > (Updated Jan. 13, 2013, 1:44 p.m.)
> > 
> > 
> > Review request for KDE Games.
> > 
> > 
> > Description
> > -------
> > 
> > The crash occurs when AI is playing or Auto attack is going on and user
> > wants to see country details from context menu. Both country and fight
> > details are shown in the right dialog interfering with each other. Some
> > safety code is added to prevent new crashes. The complete solution is to
> > disable detailed country view from the context menu when AI is playing or
> > Auto Attack is under way. This separates appearing of two views at the
> > same time in the right dialog.
> > 
> > 
> > This addresses bug 309863.
> > 
> >     http://bugs.kde.org/show_bug.cgi?id=309863
> > 
> > Diffs
> > -----
> > 
> >   ksirk/decoratedgameframe.cpp 7c6941e
> >   ksirk/krightdialog.cpp 94fd89f
> > 
> > Diff: http://git.reviewboard.kde.org/r/108068/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > 1. While AI is playing bring up context menu (right click on the country).
> > No more "Details" entry. 2. While Auto Attack bring up context menu. No
> > more "Details" entry.
> > 
> > 
> > Thanks,
> > 
> > Nemanja Hirsl
> 
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130202/c080c02
> 1/attachment-0001.html>
> 
> ------------------------------
> 
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel
> 
> 
> End of kde-games-devel Digest, Vol 117, Issue 1
> ***********************************************