[Kde-games-devel] Review Request 114674: Fix bug 310411: Crash when selecting 'Game>Restart puzzle'

[Ian Wadham]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114674/
-----------------------------------------------------------

(Updated Dec. 30, 2013, 2:52 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Games.


Bugs: 310411
    http://bugs.kde.org/show_bug.cgi?id=310411


Repository: palapeli


Description
-------

The problem occurs because no puzzle has been selected and loaded when Palapeli starts, therefore there is no puzzle to "restart".

The solution is to enable 'Game>Restart puzzle' only when a puzzle has been selected and loaded and is being solved (the action makes no sense in Palapeli's Collection mode), also to return immediately from Palapeli::Scene:restartPuzzle() if, for any other reason, no puzzle has been successfully loaded. 


Diffs
-----

  src/engine/scene.cpp 8be0925 
  src/window/mainwindow.cpp e3305fb 

Diff: https://git.reviewboard.kde.org/r/114674/diff/


Testing
-------

Tried 'Game>Restart puzzle' from Collection mode (no action) and from Puzzle mode (puzzle pieces are dismantled and re-shuffled, as expected).


Thanks,

Ian Wadham

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131230/24719647/attachment.html>