[Kde-games-devel] Review Request 114232: Make owner change combo box follow same rules for enabling as production and kill percentage.

Commit Hook null at kde.org
Sat Dec 7 18:59:56 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114232/#review45327
-----------------------------------------------------------


This review has been submitted with commit 285d5ea5a893a3b16a901be9a08bf4e49e0d7dfc by Alexander Schuch to branch KDE/4.12.

- Commit Hook


On Dec. 7, 2013, 6:35 p.m., Michael Reeves wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114232/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2013, 6:35 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 328236
>     http://bugs.kde.org/show_bug.cgi?id=328236
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> Changing the owner of a planet currently crashes if the selected player moves off the map due to a resize. Steps to reproduce are in the bug report.
> 
> 
> Diffs
> -----
> 
>   dialogs/newgamedlg.cc be764f1 
> 
> Diff: http://git.reviewboard.kde.org/r/114232/diff/
> 
> 
> Testing
> -------
> 
> Verrified that crash was fixed. Should also be applied to master but the attatched patch is against the 4.11 branch.
> 
> 
> Thanks,
> 
> Michael Reeves
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131207/0b6d498d/attachment.html>


More information about the kde-games-devel mailing list