[Kde-games-devel] Review Request 114232: Make owner change combo box follow same rules for enabling as production and kill percentage.

[Alexander Schuch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114232/#review45316
-----------------------------------------------------------

Ship it!


If you do have git, it is much easier for me to apply the patch if you do the following:

- checkout Konquest from KDE/4.11 branch
- fix the code
- commit to git locally
- create a git patch using "git format-patch"

The changes look fine. I will commit to 4.11, 4.12 and master. Thank you.

- Alexander Schuch


On Dec. 1, 2013, 3:50 a.m., Michael Reeves wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114232/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2013, 3:50 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 328236
>     http://bugs.kde.org/show_bug.cgi?id=328236
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> Changing the owner of a planet currently crashes if the selected player moves off the map due to a resize. Steps to reproduce are in the bug report.
> 
> 
> Diffs
> -----
> 
>   dialogs/newgamedlg.cc be764f1 
> 
> Diff: http://git.reviewboard.kde.org/r/114232/diff/
> 
> 
> Testing
> -------
> 
> Verrified that crash was fixed. Should also be applied to master but the attatched patch is against the 4.11 branch.
> 
> 
> Thanks,
> 
> Michael Reeves
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131207/5bc53ddd/attachment.html>