[Kde-games-devel] Review Request 111049: KNetWalk QML port

Ashwin Rajeev ashwin_rajeev at hotmail.com
Mon Aug 19 20:27:39 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111049/
-----------------------------------------------------------

(Updated Aug. 19, 2013, 8:27 p.m.)


Review request for KDE Games, Albert Astals Cid and Viranch Mehta.


Changes
-------

Replaced signals to connect functions in qml instead of invokeMethod.
Also removed ignoring blank cell. I think it would be better to add that feature in another commit.


Description
-------

QML port


Diffs
-----

  src/CMakeLists.txt d017d1a 
  src/abstractgrid.h ddd9911 
  src/cell.h 9254935 
  src/cell.cpp 7555e1d 
  src/fielditem.h 91e1a33 
  src/fielditem.cpp a04ad6e 
  src/main.cpp ce3d7a6 
  src/mainwindow.h 2c047b6 
  src/mainwindow.cpp d7d6fbd 
  src/qml/Cable.qml PRE-CREATION 
  src/qml/CanvasItem.qml PRE-CREATION 
  src/qml/Cell.qml PRE-CREATION 
  src/qml/logic.js PRE-CREATION 
  src/qml/main.qml PRE-CREATION 
  src/scene.h 7753303 
  src/scene.cpp 38c276f 
  src/view.h 9de36b8 
  src/view.cpp 95fe9b4 

Diff: http://git.reviewboard.kde.org/r/111049/diff/


Testing
-------


Thanks,

Ashwin Rajeev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130819/9804323c/attachment.html>


More information about the kde-games-devel mailing list