[Kde-games-devel] Review Request 111049: KNetWalk QML port

[Ashwin Rajeev]

> On Aug. 15, 2013, 8:42 p.m., Albert Astals Cid wrote:
> > I'm getting
> > file:///home/kdeunstable/instalado/share/apps/knetwalk/qml/CanvasItem.qml:22: ReferenceError: Can't find variable: themeProvider
> > Do you also get this? Maybe you need to add it to the engine earlier?
> 
> Ashwin Rajeev wrote:
>     I am getting this error for kbreakout too.
> 
> Albert Astals Cid wrote:
>     Right, but that's just an excuse. Can you find out why this error happens? Because having code with errors is not a good idea (if the errors are avoidable).

i mean i copied these lines from kbreakout. Anyway i fixed this error. If this fix is ok i can also copy it back to kbreakout.


- Ashwin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111049/#review37875
-----------------------------------------------------------


On Aug. 17, 2013, 7:57 a.m., Ashwin Rajeev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111049/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 7:57 a.m.)
> 
> 
> Review request for KDE Games, Albert Astals Cid and Viranch Mehta.
> 
> 
> Description
> -------
> 
> QML port
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt d017d1a 
>   src/abstractgrid.h ddd9911 
>   src/cell.h 9254935 
>   src/cell.cpp 7555e1d 
>   src/fielditem.h 91e1a33 
>   src/fielditem.cpp a04ad6e 
>   src/main.cpp ce3d7a6 
>   src/mainwindow.h 2c047b6 
>   src/mainwindow.cpp d7d6fbd 
>   src/qml/Cable.qml PRE-CREATION 
>   src/qml/CanvasItem.qml PRE-CREATION 
>   src/qml/Cell.qml PRE-CREATION 
>   src/qml/logic.js PRE-CREATION 
>   src/qml/main.qml PRE-CREATION 
>   src/scene.h 7753303 
>   src/scene.cpp 38c276f 
>   src/view.h 9de36b8 
>   src/view.cpp 95fe9b4 
> 
> Diff: http://git.reviewboard.kde.org/r/111049/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashwin Rajeev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130817/3f93e775/attachment.html>