[Kde-games-devel] Review Request 109999: Solution for bug 317907: Don't write a highscore if the score is 0.

Commit Hook null at kde.org
Sat Apr 13 19:26:58 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109999/
-----------------------------------------------------------

(Updated April 13, 2013, 7:26 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Games.


Description
-------

As said in the description, this change avoid the inclusion of the zero score in the high scores list. It doesn't make any sense to threat zero as a valid score, let alone write it in the high scores table (which is meant to expose the player's best matches).


This addresses bug 317907.
    http://bugs.kde.org/show_bug.cgi?id=317907


Diffs
-----

  mainwindow.cpp fb4b144 

Diff: http://git.reviewboard.kde.org/r/109999/diff/


Testing
-------

All the tests below were made before any score was calculated.

-- Game over.
-- Changed game's hardness before the conclusion of a stage, which interrupted the game and asked for a new one.
-- Clicked the "New Game" button before the conclusion of a stage, interrupting the current game.


Thanks,

Roney Gomes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130413/8273af01/attachment-0001.html>


More information about the kde-games-devel mailing list